Skip to content

Added translations strings to 'board details' command #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2020
Merged

Added translations strings to 'board details' command #752

merged 3 commits into from
Jun 26, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 18, 2020

Checking also i18n workflow.

cmaglie added 3 commits June 18, 2020 12:17
@cmaglie
Added translations strings to 'board details' command
b627189
@cmaglie
Removed ambigous "Identification properties" from board details
4ae6a6d 
It's the last piece of the fqbn (like the "uno" in "arduino:avr:uno").
We use it internally but there is no point in showing it in the board
details command since there is already the FQBN.
@cmaglie
Fixed plural 'Required tools' -> 'Required tool'
2aa71aa
rsora
rsora approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣️

@cmaglie cmaglie merged commit a92dcf1 into arduino:master Jun 26, 2020
@cmaglie cmaglie deleted the adding_i18n_1 branch June 26, 2020 15:10
@cmaglie cmaglie added this to the 0.12.0 milestone Jun 26, 2020
@cmaglie cmaglie self-assigned this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @rsora